Re: lynx-dev Command-line options and DOS [patch]

[Gisle Vanem]

Doug Kaufman <address@hidden> wrote:
 
> @@ -823,10 +826,18 @@
>         init_ctrl_break[0] = 1;
>      }
>      atexit(reset_break);
> -    dbug_init();
> +    for (i = 1; i < argc; i++) {
> +       if (argncmp(argv[i], "-wdebug") == 0) {
> +           parse_arg(&argv[i], &i);
> +       }
> +    }
> +    if (watt_debug)
> +    {
> +      dbug_init();
> +    }
>      sock_init();
 
I don't agree that "-wdebug" switch should be handled specially
like this (only "-help", "-show_cfg" etc. needs such special early
attention).
 
The PARSE_FUN should be sufficient provided dbug_init + sock_init are
moved much further down in main() function and after parse_arg() is
called. "-nosocks" and "-lss" should IMHO be treated similarily.
 
>     __system_flags = 0x501D;
 
This looks too cryptic. I vore to use the contants from djgpp's
<stdlib.h>:
 
    __system_flags =
       __system_emulate_chdir        |  /* handle `cd' internally */
       __system_handle_null_commands |  /* ignore cmds with no effect */
       __system_allow_long_cmds      |  /* handle commands > 126 chars  */
       __system_use_shell            |  /* use $SHELL if set */
       __system_allow_multiple_cmds  |  /* allow `cmd1; cmd2; ...' */
       __system_redirect;               /* redirect internally */
 
Gisle V.