Re: lynx-dev lynx: questions and suggestions

[Vlad Harchev]

On Fri, 26 Mar 1999, Vlad Harchev wrote:

>  Here are some questions:
>[...]
>      LSS support:
>[...]
> * To lss experts: IMO the TrimColorClass and mine FastTrimColorClass(added by 
>   my patch) calls can be avoided. They are used to compute the hash code of
>   the style that should be stacked off, and that hcode is used in the 
> following
>   way in HTML.c:HTML_end_element: 
>     HText_characterStyle(me->text, hcode, STACK_OFF);
>   The LYCurses.c:curses_w_style function doesn't use the value of the style 
>   when dir==STACK_OFF, so arbitrary value can be passed instead of hcode.
>    Eliminating TrimColorClass will eliminate the need for maintaining 
>   Style_className and can increase perfomance be 10%. 

 Done and fully tested. Idea was slightly modified. The calls now aren't
required and the contents of Style_className needn't be maintained.
 Modifications I made also fix the following bug in lynx with lss:
 When displaying HTML with nesting tags (tag X nests in tag X), the styles
were applied incorrectly:
sample:
<b> bold starts <b> nested bold </b> bold continues </b> 
Entire text should be drawn in the style for 'b', but since 
The GridText.c:_internal_HTC had the following code

 if ((style != last_style || dir != last_dir) && line->numstyles <
MAX_STYLES_ON_LINE) {
  /* assigning styles, otherwise exiting*/
 }
 only 'bold starts nested bold' was drawn in bold style. Condition should be
 if ( line->numstyles < MAX_STYLES_ON_LINE) {
  /*....*/
 }
instead.
  
 But I didn't make call elimination yet.
 Patch will be sent to the release of lynx that will contain patch for
source syntax highlighting(aka 'huge').

 Best regards,
  -Vlad