[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: lynx-dev Lynx Litter on VMS
From: |
brian j. pardy |
Subject: |
Re: lynx-dev Lynx Litter on VMS |
Date: |
Wed, 14 Oct 1998 08:03:52 -0700 (PDT) |
On Wed, 14 Oct 1998 address@hidden wrote:
> > +
> > + #ifdef VMS
> > + /*
> > + * Get rid of any copies of the cookie file that VMS creates.
> > + */
> > +
> > + StrAllocCopy(VMScookie_file, cookie_file);
> > + StrAllocCat(VMScookie_file, ";-1");
> > +
> > + while (remove(VMScookie_file) == 0) ;
> > + /*
> > + * Reset version number.
> > + */
> > + StrAllocCopy(VMScookie_file, cookie_file);
> > + StrAllocCat(VMScookie_file, ";1");
> > + rename(cookie_file, VMScookie_file);
> > + #endif /* VMS */
>
> The last couple of lines are redundant and error-prone. If the remove loop
> fails due to permissions, you'll end up renaming the most recent file to a
> lower version than the possible older file. So I'd simply omit that.
>
> (I'll add the first part to pre.10, since I don't see anything else
> wrong)
Ah, okay. That sounds good to me.
In that case you might want to have a look at the similar code for the
.lynxrc file, I grabbed it and barely modified it.
> > +
> > }
> > #endif
--
GPG & PGP public keys: <URL:http://www.psnw.com/~posterkid/keys/>
PGP fingerprint: 42 57 B3 D2 39 8E 74 C3 5E 4D AC 43 25 D2 26 D4