[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-users] Default AVR32 framework LwIP input path
From: |
Sylvain Rochet |
Subject: |
Re: [lwip-users] Default AVR32 framework LwIP input path |
Date: |
Fri, 27 Apr 2012 17:03:42 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi,
On Fri, Apr 27, 2012 at 04:23:11PM +0200, Simon Goldschmidt wrote:
> Sylvain Rochet <address@hidden> wrote:
> > lwip-port/AT32UC3A/netif/ethernetif.c::ethernetif_input() function from
> > the AVR32-SoftwareFramework-1.0.0-AT32AP7000 looks like:
> >
> > static void ethernetif_input(void * pvParameters) {
> > -wait for macb and loop packet input, not important- {
> > if( ERR_OK != ethernet_input( p, netif ) ) {
> > -free, ..., not important-
> > [..]
> > I am wrong saying
> > that this is just defective by design and MUST be replaced by
> > "netif->input(p, netif)" which calls tcpip_input() and put the packet on
> > the packet input box ?
>
> That looks indeed wrong (at least when using lwIP with NO_SYS==0,
> which seems like what they do, seeing they pass 'tcpip_input' to
> 'netif_add) and your suggested fix (calling netif->input() instead of
> ethernet_input()) is correct, yes.
Thanks for the confirmation.
So, for all of us using the Atmel AVR32 framework, we need to fix this
design bug which might send us into deep trouble :-)
By the way, I wrote a AVR32UC3 LwIP port working with the current LwIP
HEAD revision, what's the best way to contribute this one to the
community ?
Sylvain
signature.asc
Description: Digital signature