Re: [lwip-users] Default AVR32 framework LwIP input path

[Simon Goldschmidt]

Sylvain Rochet <address@hidden> wrote:
> lwip-port/AT32UC3A/netif/ethernetif.c::ethernetif_input() function from 
> the AVR32-SoftwareFramework-1.0.0-AT32AP7000 looks like:
> 
> static void ethernetif_input(void * pvParameters) {
>   -wait for macb and loop packet input, not important- {
>     if( ERR_OK != ethernet_input( p, netif ) ) {
>        -free, ..., not important-
> [..]
> I am wrong saying 
> that this is just defective by design and MUST be replaced by 
> "netif->input(p, netif)" which calls tcpip_input() and put the packet on 
> the packet input box ?


That looks indeed wrong (at least when using lwIP with NO_SYS==0, which seems 
like what they do, seeing they pass 'tcpip_input' to 'netif_add) and your 
suggested fix (calling netif->input() instead of ethernet_input()) is correct, 
yes.

Simon
-- 
Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir
belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de