[lwip-devel] [patch #9860] mdns: fixes for Bonjour Conformance Tests

[David GIRAULT]

Follow-up Comment #3, patch #9860 (project lwip):

Hi Simon,

[comment #1 commentaire #1 :]
> Thanks for sharing this! And sorry for taking so long to review.
> 
> The patches overall look good, however, some comments:
> 
> - some typos in commit messages and comments here and there...

I'll try to fix the one I can find.

> 
> - patch 1 increases memory usage. This should probably be a config option,
and be prefixed correctly (LWIP_MDNS_OUTPACKET_SIZE, not just OUTPACKET_SIZE)

Ok, will rename & move it to mdns_opts.h.

> - patch 4: instead of repeating MDNS_INITIAL_PROBE_DELAY_MS and
MDNS_PROBE_DELAY_MS all over the place, could you hide this in two functions
(e.g. mdns_resp_restart() and mdns_resp_restart_initial())?

You're right. This is a better solution.

> - patch 6: please improve the description of MDNS_MAX_STORED_PKTS and how it
affects memory consumption (e.g. what is this used for, so that people can
imagine how big this gets)

Ok.


> - patch 9: this 50ms offset seems kind of random?

You're right. It's a problem. I'll move if as an option in mdns_opts.h with
the default value of 250.

> 

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9860>

_______________________________________________
  Message posté via Savannah
  https://savannah.nongnu.org/