[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #9860] mdns: fixes for Bonjour Conformance Tests

From: Simon Goldschmidt
Subject: [lwip-devel] [patch #9860] mdns: fixes for Bonjour Conformance Tests
Date: Tue, 3 Dec 2019 16:13:17 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.108 Safari/537.36

Update of patch #9860 (project lwip):

                  Status:                    None => In Progress            
             Assigned to:                    None => goldsimon              


Follow-up Comment #1:

Thanks for sharing this! And sorry for taking so long to review.

The patches overall look good, however, some comments:

- some typos in commit messages and comments here and there...

- patch 1 increases memory usage. This should probably be a config option, and
be prefixed correctly (LWIP_MDNS_OUTPACKET_SIZE, not just OUTPACKET_SIZE)
- patch 4: instead of repeating MDNS_INITIAL_PROBE_DELAY_MS and
MDNS_PROBE_DELAY_MS all over the place, could you hide this in two functions
(e.g. mdns_resp_restart() and mdns_resp_restart_initial())?
- patch 6: please improve the description of MDNS_MAX_STORED_PKTS and how it
affects memory consumption (e.g. what is this used for, so that people can
imagine how big this gets)
- patch 9: this 50ms offset seems kind of random?


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]