[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lwip-devel] [PATCH v2] PPP, PPPoE: Use service name and concentrato

From: Sylvain Rochet
Subject: Re: [lwip-devel] [PATCH v2] PPP, PPPoE: Use service name and concentrator name
Date: Thu, 20 Dec 2018 14:10:22 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

Hi Jabob,

On Thu, Dec 20, 2018 at 03:01:34AM +0100, Jacob Kroon wrote:
>  * Make pppoe_create() actually store the passed service name and
>    concentrator name, so that they are passed in the PADI/PADR/PADS packets
>  * Assume that the user application won't be freeing the strings and
>    just copy the string pointers, therefore remove the mem_free() in
>    pppoe_destroy()
>  * Since only the pointers are copied now, make them 'const' in pppoe_softc
> ---
>  src/include/netif/ppp/pppoe.h |  4 ++--
>  src/netif/ppp/pppoe.c         | 15 ++++++---------
>  2 files changed, 8 insertions(+), 11 deletions(-)
> V2:
>   Only copy the string pointers, not the contents, so remove freeing in
>   pppoe_destroy() and make the pointers const

Perfect, applied, thanks ! :)


Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]