Re: [lwip-devel] [PATCH v2] PPP, PPPoE: Use service name and concentrator name

[Jacob Kroon]

Hi Sylvain,

On Thu, Dec 20, 2018 at 2:23 PM Sylvain Rochet <address@hidden> wrote:
>
> Hi Jabob,
>
> On Thu, Dec 20, 2018 at 03:01:34AM +0100, Jacob Kroon wrote:
> >  * Make pppoe_create() actually store the passed service name and
> >    concentrator name, so that they are passed in the PADI/PADR/PADS packets
> >  * Assume that the user application won't be freeing the strings and
> >    just copy the string pointers, therefore remove the mem_free() in
> >    pppoe_destroy()
> >  * Since only the pointers are copied now, make them 'const' in pppoe_softc
> > ---
> >  src/include/netif/ppp/pppoe.h |  4 ++--
> >  src/netif/ppp/pppoe.c         | 15 ++++++---------
> >  2 files changed, 8 insertions(+), 11 deletions(-)
> >
> > V2:
> >   Only copy the string pointers, not the contents, so remove freeing in
> >   pppoe_destroy() and make the pointers const
>
> Perfect, applied, thanks ! :)
>

No problem ! :-)
Would it possible to get the PPPOE_SCNAME_SUPPORT merged to the 2.1.x
branch ? If so, how would I proceed with that request ?