[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #52763] mdns: move data off the stack and dynamically

From: Erik Ekman
Subject: [lwip-devel] [bug #52763] mdns: move data off the stack and dynamically allocate data.
Date: Sun, 31 Dec 2017 07:38:51 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Fedora; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.62 Safari/537.36

Follow-up Comment #4, bug #52763 (project lwip):

Nice to see progress. Some more comments:

For LWIP_ERROR, I think this is the minimal definition:

#define LWIP_ERROR(message, expression, handler) do { if (!(expression)) {
handler; }} while(0)

Asserts and the logging message can be ignored, but not the handler as I
understand it.

realloc isnt supported by the lwIP memory abstraction, it was renamed mem_trim
since it could only shrink the allocation - so we needed to stop using realloc

Please check if test/unit/mdns/test_mdns.c needs to be updated as well  - you
can run it from ports/unix/check in the contrib repo.

You don't need the semicolon after the 'err:' label.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]