Re: [lwip-devel] sockets.c: Possible to return from lwip_select without decrementing sockets used

[address@hidden]

Thanks for the patches, I've just pushed them. However, we prefer to have patches sent to our patch tracker at https://savannah.nongnu.org/patch/?group=lwip since they easily get overlooke here in times where there are many mails and too little man power to catch up...

Cheers,
Simon


Tim Cussins:

Hi all,

Just updated to 0952e618, and found an issue in lwip_select:
It looks like we return without decrementing appropriate fd_used
when lwip_selscan returns < 0. See first patch.

Also included is a super bonus patch for sock_inc_used(), which
currently might fail to notice an overflow. The patch ensures
that the inc and test are done atomically.

Cheers,
Tim

_______________________________________________
lwip-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/lwip-devel