[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] sockets.c: Possible to return from lwip_select without decr

From: Tim Cussins
Subject: [lwip-devel] sockets.c: Possible to return from lwip_select without decrementing sockets used
Date: Tue, 18 Apr 2017 15:46:00 +0100

Hi all,

Just updated to 0952e618, and found an issue in lwip_select:
It looks like we return without decrementing appropriate fd_used
when lwip_selscan returns < 0. See first patch.

Also included is a super bonus patch for sock_inc_used(), which
currently might fail to notice an overflow. The patch ensures
that the inc and test are done atomically.


Attachment: 0001-sockets.c-Add-missing-lwip_select_dec_sockets_used-w.patch
Description: Text Data

Attachment: 0002-sockets.c-Make-sock_inc_used-overflow-check-robust.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]