[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #8882] Vector improvements

From: Joel Cunningham
Subject: [lwip-devel] [patch #8882] Vector improvements
Date: Thu, 16 Feb 2017 19:51:18 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

Follow-up Comment #32, patch #8882 (project lwip):

As I was working on updating my old patch, I was studying
lwip_netconn_do_writemore() and one thing that is curious is why write_offset
is a member of struct netconn and not struct api_msg (under the "w" union).

write_offset is only used by lwip_netconn_do_writemore() to store offset into
the dataptr.  When a write is not in progress, the variable seems to have no
use.  I'm wonder if write_offset could be relocated to struct api_msg and
reduce the size of struct netconn.

Digging through git, it looks like write_offset was added with 3 others way
back in 9f05cabf872919828eda2138170e6eaded510fdf.  

My vector work is looking at having to add an offset into current vector in
addition to write_offset and it might be better to put that in struct api_msg


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]