[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #8882] Vector improvements

From: Joel Cunningham
Subject: [lwip-devel] [patch #8882] Vector improvements
Date: Fri, 24 Feb 2017 16:55:54 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

Follow-up Comment #39, patch #8882 (project lwip):

Below discussed cleanups committed in

Also made some minor cleanups in netconn_write_partly committed in

(from commit message):

This commit changes netconn_write_partly to use msg.w.offset to set
bytes_written for both blocking and non-blocking connections

This is correct because msg.w.offset is the canonical output from
the do_write call and in the case that not all bytes were written,
(a bug?) returning the full size to the caller is dangerous

Lastly, this commit adds an assert for the blocking case to sanity
check that all the bytes we requested were written.  This will help
catch bugs in do_write

Let me know if you have any questions, thanks!

Also, I'm getting back to rebasing my vector patch, hopefully have it posted
this weekend or next week


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]