[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lwip-devel] A few issues

From: Simon Goldschmidt
Subject: Re: [lwip-devel] A few issues
Date: Mon, 18 May 2009 14:34:44 +0200

> * Two compiler warnings:
> lwip/ip.h:66: warning: function declaration isn’t a prototype
> lwip/ip.h:67: warning: function declaration isn’t a prototype

I'll have a look into that. Maybe the correct includes are missing.

> * When using NO_SYS == 1 I get an compiler error because the definition 
> of sys_prot_t is missing. All is fine in NO_SYS == 0 as in this case 
> sys.h includes sys_arch.h which defines sys_prot_t. Shouldn't the 
> sys_arch.h include be moved to the top of sys.h so it gets included for 
> both NO_SYS == 0/1? Or is sys_arch.h only intended to be used in the 
> NO_SYS == 0 case? Where should sys_prot_t then be defined?

We agreed on defining it where all the other typedefs are defined: cc.h. Might 
not be the cleanest solution, but including sys_arch.h when NO_SYS=1 is 
definitively wrong. Anyway, you only need the typedef when using 
lightweight-protection, which you couldn't before that change...

Thanks for reporting.
Neu: GMX FreeDSL Komplettanschluss mit DSL 6.000 Flatrate + Telefonanschluss 
für nur 17,95 Euro/mtl.!* 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]