[lwip-devel] [task #7017] Implement DNS client

[Frédéric Bernon]

Follow-up Comment #34, task #7017 (project lwip):

Good job ! Only some details to see:

- I will add in sockets.h :

#define h_addr h_addr_list[0]  /* for backward compatibility */

- I will remove from sockets.h the lwip_fill_hostent define, and move it in
sockets.c (or directly in gethostbyname since this is the only place where it
is used)

- lwip_fill_hostent seems wrong (?): h_aliases should not be NULL, but
h_aliases[0] can be set to NULL. h_addr_list can't be a pointer to
s_hostent_addr, but h_addr_list[0] is.

- I'm not sure that SYS_ARCH_DECL_PROTECT/SYS_ARCH_PROTECT/SYS_ARCH_UNPROTECT
(in gethostbyname) give any protection. But in all cases, as I said in comment
#29, I want to got a solution with macros to let the port choose between a
"static" or a "per-thread" set of variables if it's need it (and support it).

In all cases, you can check in your patch (I will do my changes later)...


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7017>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/