[lwip-devel] [patch #6250] MSG_MORE flag for send

[Jonathan Larmour]

Follow-up Comment #2, patch #6250 (project lwip):

[ Moving this discussion to patch from list ]


Frédéric BERNON wrote:
> 
> Without adding a new parameter, since the existing "copy" 
> parameter seems to be forwarded from sockets.c to tcp_out.c
> (in tcp_enqueue), why don't use it? We can rename it apiflags -
> or something else - (since flags is usein tcp_enqueue like "tcp
> flags"). I don't have study all case, but msg_more is an option
> "per 'write' call", like the "copy" option.

I think that's a very good idea.

Marc CHALAND wrote:
> This was my first idea. I didn't want to disturb eventual
> special use of this byte ?

I think this counts as special use :-).

> However, this require change of tcp_write and so on
> functions...

As does your proposed patch, but here we are only changing the name of
'copy', which obviously doesn't change code size. Only tcp_enqueue actually
has to mask off bits.

I think this works right up to netconn_write() too, so that would change from
'copy' to 'apiflags' too. In the apiflags, 1 would mean "copy", thus
preserving existing API behaviour. So we even get away with no API backward
compatibility problem.



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6250>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/