lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 3a64b87 094/156: Correct misleading comment f


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 3a64b87 094/156: Correct misleading comment for page class dtor
Date: Tue, 30 Jan 2018 17:22:20 -0500 (EST)

branch: master
commit 3a64b87134cb23b96c039c40c9cf21898a8c9097
Author: Vadim Zeitlin <address@hidden>
Commit: Vadim Zeitlin <address@hidden>

    Correct misleading comment for page class dtor
    
    Pages are used polymorphically, so don't say they are not.
---
 ledger_pdf_generator_wx.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ledger_pdf_generator_wx.cpp b/ledger_pdf_generator_wx.cpp
index cf2d757..8871eb5 100644
--- a/ledger_pdf_generator_wx.cpp
+++ b/ledger_pdf_generator_wx.cpp
@@ -587,8 +587,7 @@ class page
     page(page const&) = delete;
     page& operator=(page const&) = delete;
 
-    // Pages are never used polymorphically currently, but still give them a
-    // virtual dtor, if only to avoid gcc warnings about not having it.
+    // Make base class dtor virtual.
     virtual ~page() = default;
 
     // Called before rendering any pages to prepare for doing this, e.g. by



reply via email to

[Prev in Thread] Current Thread [Next in Thread]