[lmi-commits] [lmi] master ea20a31 095/156: Make pdf_illustration dtor virtual

[Greg Chicares]

branch: master
commit ea20a3100378521fdb7099fdfb06e37f0312bfee
Author: Vadim Zeitlin <address@hidden>
Commit: Vadim Zeitlin <address@hidden>

    Make pdf_illustration dtor virtual
    
    This is required in order to delete the derived class objects via a
    pointer to the base class as we do in ledger_pdf_generator_wx::write(),
    until this commit this resulted in undefined behaviour which just
    happened to not have any consequences in practice because all the
    derived classes dtors were trivial and they didn't add any fields.
---
 ledger_pdf_generator_wx.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ledger_pdf_generator_wx.cpp b/ledger_pdf_generator_wx.cpp
index 8871eb5..0c4414a 100644
--- a/ledger_pdf_generator_wx.cpp
+++ b/ledger_pdf_generator_wx.cpp
@@ -648,6 +648,9 @@ class pdf_illustration : protected html_interpolator
         init_variables();
     }
 
+    // Make base class dtor virtual.
+    virtual ~pdf_illustration() = default;
+
     // Add a page.
     //
     // This is a template just in order to save on writing std::make_unique<>()