[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] [Patch] Real-Time Text (RFC4103) for linphone

From: Martin Hörlin
Subject: Re: [Linphone-developers] [Patch] Real-Time Text (RFC4103) for linphone
Date: Wed, 07 Sep 2011 14:31:11 +0200
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0.1) Gecko/20110830 Thunderbird/6.0.1

Hi Jehan, thanks for your feedback.

The main difference between IM and real-time text is that in IM messages are sent as whole when the user is done typing them while in real-time text you send character by character while the user is typing them, you also send special characters like backspace.

I think it would be possible to modify "linphone_chat_room_send_message" to be able to handle real-time text. You would still need to tell the user interface that it is dealing with real-time text so it know that it should call "send_message" on every letter and not after a finished sentence, the user would probably also want to know that  everything is sent directly and not after enter.

I am a bit worried that calling "linphone_chat_room_text_received" on every received character on the textstream would risk slowing down the user interface on a low end device.

Any thoughts?


Jehan Monnier skrev 2011-09-07 11:30:
Dear Martin,

Thanks for your updated patch.

I'm concerned by the new "realtime text api" you added. Linphone already has a "text API" for IM. I believe it would be better to use this existing API for realtime text. 
Implementation of linphone_chat_room_send_message can automatically route messages to the realtime text stream if any.
You can also add a method to create a char room from a call.

I'll integrate your oRTP patch.

Best regards

Le 26 août 2011 à 11:46, Martin Hörlin a écrit :

Hi Jehan,

Thanks for looking into my patch, sorry for taking so long to get back to you, I was on summer vacation.
Here is an updated version of the patch, using the latest linphone-android trunk. I included the a/b prefixes this time.


Jehan Monnier skrev 2011-07-06 11:27:
Hi Martin,

Thanks for your patch. 

Your *.patch file do not apply as is to linphone.
I've got the following error with git apply :

mac-book-de-jehan-monnier:oRTP jehanmonnier$ git apply   ~/Desktop/patch_linphone_with_rfc4103/ortp.patch 
error: ortp/payloadtype.h: No such file or directory
error: avprofile.c: No such file or directory

Looking into ortp.patch it seam the a/b prefix are missing:
diff --git include/ortp/payloadtype.h include/ortp/payloadtype.h
index 97c427d..34d970b 100644
--- include/ortp/payloadtype.h
+++ include/ortp/payloadtype.h
@@ -47,7 +47,8 @@ extern "C"{

I'm expecting something like:
diff --git a/include/ortp/payloadtype.h b/include/ortp/payloadtype.h
index 97c427d..34d970b 100644
--- a/include/ortp/payloadtype.h
+++ b/include/ortp/payloadtype.h
@@ -47,7 +47,8 @@ extern "C"{


Le 1 juil. 2011 à 11:56, Martin Hörlin a écrit :

Hello everyone,

We have made a patch for Linphone with the hope that Real-Time Text (RFC 4103) can be added to the Linphone opensource project. Real-Time Text is mainly used in telecommunication by people who are deaf or hard of hearing.

The patch is based on the latest linphone-android project. More info about the patch there is a README file in the tar archive and I also included an apk for anyone that wants to try it out without compiling.

I did submit a patch earlier but I think it might have been lost so I made a new updated one.

Best Regards,
Martin Hörlin
Med vänlig hälsning
Omnitor AB
Martin Hörlin
Taltelefon: 08-589 000 71 : Fax: 08-589 000 51
Besöksadress: Hammarby Allé 93, 1 tr. SE-120 63 Stockholm Sweden
Postadress: Box 92054 SE-120 06 Stockholm Sweden
Linphone-developers mailing list

Linphone-developers mailing list

Linphone-developers mailing list

Linphone-developers mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]