[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] [Q] Bug of linphone-1.0.1?

From: Simon Morlat
Subject: Re: [Linphone-developers] [Q] Bug of linphone-1.0.1?
Date: Tue, 31 May 2005 20:49:10 +0200
User-agent: KMail/1.7.2

Hello Clement,

Thanks for the patch. I took some time to review it. This is good and very 
complete work ..... but there's only one little detail that hurts me:

extern gboolean play_file_stream;
extern gboolean endless_play;

That we can find in several places in your patch. This really breaks the 
object model followed by linphone. I think the place for those booleans is in 
AudioStream. The endless_play should be passed as argument to the MSRead 
using a ms_read_set_endless_mode() like function and may be stored in the 
MSRead structure for use within the process function.
Then the LinphoneCore structure should own those boolean as well as the play 
file paths, then should pass it to AudioStream functions.

All MSFilter objects should be independant. It should be possible to create a 
MSRead running in endless_play mode while another is not. Same thing for 
AudioStream: you should be able to create two AudioStream and run them 
simultaneously, each one with its own parameters.

If you submit me another patch with this little problem fixed, I'll be happy 
to merge it into the CVS. If I had more time I could fix it myself but 
unfortunately this is not the case.

Just one question: why did you add a file_16k boolean parameter while the rate 
is usually stored within the wav header of the file ? Note that the 
MSRingPlayer filter does the same thing as MSRead except that it is able to 
read wav files and it is already able to run in endless loop.


Le Vendredi 20 Mai 2005 21:15, Clement Chen a écrit :
> Hi, Simon,
>     The attached is the patch for linphone-1.0.1 to provide file
> stream playing features FYI. During a call, a file stream or voice
> stream can be switched dynamically. (DTMF strings will not be played
> locally when the file stream is used) When a file stream ends playing,
> a call back function can be triggered to report this information.
> Currently I only register one for linphonec. The GUI version of
> linphone may use another call back function instead, since it may show
> that information in a GUI component.
>     I didn't seem to modify codes relating to SDP processing... and
> this error also occured when the original linphone-1.0.1 build is
> used. My OS is fedora core 3, libosip is libosip2-2.2.0, and speex
> 1.1.7. I used "--enable-alsa --with-speex=/usr/local" options to
> configure the make file.
> Information for other libraries:
> jack (from its CVS repository)
> libsamplerate-0.1.2-1
> libsamplerate-devel-0.1.2-1
> libsndfile-1.0.11-1.1.fc3
> libsndfile-devel-1.0.11-1.1.fc3
>     To use the attached patch, here are the steps:
> 1. gunzip linphone-1.0.1.patch.gz
> 2. patch -d <parent dir. of your linphone-1.0.1 original source> -p0 <
> ./linphone-1.0.1.patch
>     for example, if your source is in /usr/local/src/linphone-1.0.1,
> you should run
>     patch -d /usr/local/src -p0 < ./linphone-1.0.1.patch
> Thanks a lot! :)
> Clement.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]