[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] RTP sessions not being removed from oRTP sched

From: Simon MORLAT
Subject: Re: [Linphone-developers] RTP sessions not being removed from oRTP scheduler
Date: Wed, 29 Oct 2003 15:01:10 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20031018 Thunderbird/0.2


You are right. Thank you very much. It is now commited to the CVS.
Evan Pfeiffer wrote:

A comment on what appears to be a bug in oRTP.

When an RTP session is removed using rtp_session_destroy() it is not removed from the scheduler if the session has not sent or received any packets.

This seems erroneous as the scheduler will be left with a session that has been deallocated by rtp_session_destroy(). Shouldn't a session that has been added to the scheduler always be removed by rtp_session_uninit()?

I suggest the following patch to rtpsession.c (diff generated for oRTP 0.6.2)

<         if ((!(session->flags & RTP_SESSION_RECV_NOT_STARTED))
<             || (!(session->flags & RTP_SESSION_SEND_NOT_STARTED)))
< rtp_scheduler_remove_session (session->sched,session);
>         rtp_scheduler_remove_session (session->sched,session);


Linphone-developers mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]