[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Linphone-developers] RTP sessions not being removed from oRTP scheduler

From: Evan Pfeiffer
Subject: [Linphone-developers] RTP sessions not being removed from oRTP scheduler
Date: Wed, 29 Oct 2003 17:25:21 +1030
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0

A comment on what appears to be a bug in oRTP.

When an RTP session is removed using rtp_session_destroy() it is not removed from the scheduler if the session has not sent or received any packets.

This seems erroneous as the scheduler will be left with a session that has been deallocated by rtp_session_destroy(). Shouldn't a session that has been added to the scheduler always be removed by rtp_session_uninit()?

I suggest the following patch to rtpsession.c (diff generated for oRTP 0.6.2)

<            if ((!(session->flags & RTP_SESSION_RECV_NOT_STARTED))
<                    || (!(session->flags & RTP_SESSION_SEND_NOT_STARTED)))
<                      rtp_scheduler_remove_session (session->sched,session);
>            rtp_scheduler_remove_session (session->sched,session);


reply via email to

[Prev in Thread] Current Thread [Next in Thread]