[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GSoC 2020: Unexpected "regressions"...
From: |
Owen Lamb |
Subject: |
Re: GSoC 2020: Unexpected "regressions"... |
Date: |
Sat, 29 Aug 2020 16:50:15 -0700 |
On Sat, Aug 29, 2020 at 2:39 AM Werner LEMBERG <wl@gnu.org> wrote:
>
> > Ah! It looks like the issue is in line 12 of palm-mute.ly:
> >
> > e8^\markup { \musicglyph "noteheads.u2do" = palm mute }
> >
> > Here, \musicglyph is looking for noteheads.u2do, which I combined
> > with .d2do to make .s2do. Changing the string to "noteheads.s2do"
> > makes this regression test work as expected again.
> >
> > (Is it permissible to simply update this regtest as part of the main
> > commit, or is there a better way to do it?)
>
> If you mean you should simply add another commit to your branch to fix
> this, then yes :-)
>
Ah. No, I meant re-committing my first commit with the fix, then rebasing
the dev/lamb/GSoC-2020-final branch on top of it to keep my history pretty.
Would you rather I just made a new commit?
--Owen
Re: GSoC 2020: Unexpected "regressions"..., Han-Wen Nienhuys, 2020/08/28