lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] switch to Gerrit


From: Jonas Hahnfeld
Subject: Re: [RFC] switch to Gerrit
Date: Wed, 11 Mar 2020 19:19:21 +0100
User-agent: Evolution 3.34.4

Am Mittwoch, den 11.03.2020, 18:55 +0100 schrieb Han-Wen Nienhuys:
> On Wed, Mar 11, 2020 at 5:09 PM Jonas Hahnfeld <
> address@hidden
> > wrote:
> > > > > Right now, LilyPond's source code is hosted on Savannah [1], our 
> > > > > issues
> > > > > are tracked on SourceForge [2] and we review patches on Rietveld [3].
> > > > > There is no synchronization between the systems and a contributor is
> > > > > required to synchronize the review and the associated issue.
> > > > > 
> > > > > I propose to start using self-hosted Gerrit for doing code
> > > > > reviews and code review status tracking. Gerrit has integrated Git
> > > > > hosting, and integrated code viewing
> > > > 
> > > > Hm, a presentation by Google itself claims that "Gerrit does not
> > > > provide [...] Code Browsing, Code Search" [1] If I look on GerritHub,
> > > > it has links to GitHub [2] and that's something we don't want to use as
> > > > far as I understand.
> > > > 
> > > > 1: 
> > > > https://docs.google.com/presentation/d/1C73UgQdzZDw0gzpaEqIC6SPujZJhqamyqO1XOHjH-uk/edit#slide=id.g4d6c16487b_1_140
> > > > 
> > > > 2: 
> > > > https://review.gerrithub.io/admin/repos/q/filter:lilypond
> > > > 
> > > > 
> > > 
> > > The Gerrit code per se does not have browsing, but it has hooks to expose 
> > > a viewer in the UI. Some sites use the CGit viewer, but there is also 
> > > gitiles, which is a plugin, and will also respect Gerrit permissions. 
> > > Gitiles source code is here:
> > > 
> > >   
> > > https://gerrit.googlesource.com/plugins/gitiles/
> > > 
> > > 
> > > that link is served from gitiles.  Gitiles is a "core" plugin for gerrit.
> > > 
> > > I filed a bug about the code viewer on gerrithub (the URLs are malformed.)
> > 
> > Did this lead somewhere? I still see "Repository Browser: GitHub" on
> > link [2] above.
> 
> I guess not.
> 
> > Also I just saw the following in the initial message:
> > > Gerrit as hosted by GerritForge requires a GitHub account. If this is
> > > an issue, I volunteer to manage a self-hosted Gerrit instance.
> > 
> > I firmly believe that self-hosting is not the right approach unless
> > absolutely necessary. Do you know of any other hosted Gerrit instance
> > that comes with its own authentication service?
> 
> Gerrit itself does not have an authentication service. See
> https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#auth
> 
> ; I guess in our circumstances, we could do OAuth on top of Google,
> Github or Facebook accounts.
> 
> What do you mean with "own authentication service" ?

I mean: Is there a hosted Gerrit that does not require a GitHub
account? Ideally with the possibility to create an account just for
that.

Jonas

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]