lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Issue 5309, take 2: find_global_context () and find_score_context () (is


From: lemzwerg
Subject: Issue 5309, take 2: find_global_context () and find_score_context () (issue 561290043 by address@hidden)
Date: Fri, 03 Jan 2020 08:18:09 -0800

LGTM, thanks!


https://codereview.appspot.com/561290043/diff/583280043/lily/context.cc
File lily/context.cc (right):

https://codereview.appspot.com/561290043/diff/583280043/lily/context.cc#newcode116
lily/context.cc:116: if (Context *score = gthis->get_score_context ())
Not sure whether compilers warn about the `if (... = ...)` construct.
Perhaps the `Context *` prevents it.  Otherwise I suggest another level
of parentheses.

https://codereview.appspot.com/561290043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]