Re: Please test gub

[Alexander Kobel]

On 08.02.19 14:12, Knut Petersen wrote:
> Hi everybody!
> > >      Use /usr/bin/env python2? Does every python 2.x installation 
> > > really contain a python2 executable?
> > >      OSX 10.12 Sierra has python 2.7 but does not have a python2 
> > > executable.  Only python.
> > >
> > > At least this is the case on my machine.
> >
> > Gosh, didn't expect that.
> >
> > In that case, I'd vote for leaving python shebangs as they are.
> >
> > Arch is clearly not following (one of) the recommendation in the PEP, 
> > that python "should" deliver python2. So it's Arch's fault, and their 
> > (packagers/users') responsibility to take appropriate action.
> Again, something to document ;-)
>
> Gub itself does not provide a python2.
>
> I think with the attached test-patch on top of the patch I already sent 
> to you 'make lilypond' (not only bin/gub xxx::lilypond) should succeed 
> after you put the newly created wrapper directory in front of PATH.

I see; this wrapper directory is more convenient than asking the user to 
provide a dir with only the symlinks python{,-config} -> 
/some/where/python2{,-config} on his own and add it to the PATH.

But isn't it against the purpose that now the shebangs of bin/gub/* read

#! /usr/bin/env python2

? I think you meant: add the wrapper directory PATH such that we *don't* 
have to replace python by python2 in those shebangs.

-TARGET_PYTHON=/usr/bin/python
+TARGET_PYTHON=/usr/bin/env python

in gub/specs/lilypond{,-doc}.py (rather than python2) is necessary and 
(almost) correct in the patch, though.


Cherry-picking only those changes, everything seems to start fine.


Cheers,
Alex

smime.p7s
Description: S/MIME Cryptographic Signature