Re: Let ChordNameVoice use the same performers as Voice (issue 7054043)

[dak]

Reviewers: lemzwerg, J. Rohrer,

Message:
On 2013/01/04 19:32:02, J. Rohrer wrote:

> [Thus I learned something about contexts today: I would not have
naively
> expected

>    \context { \AlreadyDefinedContext \name NewContext },

> to actually create a new, independent context, since the command looks
more like
> a tweak on \AlreadyDefinedContext. But obviously this is useful.]

\AlreadyDefinedContext _always_ creates a new, independent context copy.
 It is just that at the end of the context definition, whatever the name
ends up to be is telling the output definition just where to write this
new context definition.  If you don't change the \name, it is going to
end up in the place of the old definition.

Description:
Let ChordNameVoice use the same performers as Voice

In particular, ties should be heeded when creating Midi from a
ChordNames context as they result in the omission of the engraved
chord name if an identical chord follows.  Reasoning for beams and
slurs is fuzzier, but an articulation different from the same music in
a regular Voice context does not seem to make sense.

Please review this at https://codereview.appspot.com/7054043/

Affected files:
  M ly/performer-init.ly


Index: ly/performer-init.ly
diff --git a/ly/performer-init.ly b/ly/performer-init.ly
index  
fddfbf09188e839542ae21ad77fdf281f3fb37b4..f26ed9f87db639f8ad93ff8142eebb05193c469c  
100644
--- a/ly/performer-init.ly
+++ b/ly/performer-init.ly
@@ -271,8 +271,7 @@
 }

 \context {
-  \type "Performer_group"
-  \consists "Note_performer"
+  \Voice
   \name ChordNameVoice
 }