[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix for beaming in Kievan notation (issue 6305080)
From: |
aleksandr . andreev |
Subject: |
Re: Fix for beaming in Kievan notation (issue 6305080) |
Date: |
Wed, 08 Aug 2012 19:20:35 +0000 |
On 2012/08/07 18:19:14, dak wrote:
http://codereview.appspot.com/6305080/diff/4001/lily/beam.cc#newcode636
lily/beam.cc:636: extract_grob_set (stems[0], "note-heads", heads);
This looks like the wrong place to do this calculation. You overwrite
what has
been put into quantized-positions here. It looks like you should
rather move
the calculation to the place where quantized-positions is initialized,
Agreed. However, I cannot figure out where the appropriate place for
these calculations should be.
http://codereview.appspot.com/6305080/