[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix for beaming in Kievan notation (issue 6305080)
From: |
dak |
Subject: |
Re: Fix for beaming in Kievan notation (issue 6305080) |
Date: |
Tue, 07 Aug 2012 18:19:14 +0000 |
http://codereview.appspot.com/6305080/diff/4001/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/6305080/diff/4001/lily/beam.cc#newcode636
lily/beam.cc:636: extract_grob_set (stems[0], "note-heads", heads);
This looks like the wrong place to do this calculation. You overwrite
what has been put into quantized-positions here. It looks like you
should rather move the calculation to the place where
quantized-positions is initialized, or the behavior will be rather
intransparent.
http://codereview.appspot.com/6305080/