[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix critical regressions to lyric spacing (issue4061043)
From: |
n . puttock |
Subject: |
Re: Fix critical regressions to lyric spacing (issue4061043) |
Date: |
Sun, 23 Jan 2011 22:55:54 +0000 |
http://codereview.appspot.com/4061043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
http://codereview.appspot.com/4061043/diff/1/Documentation/changes.tely#newcode70
Documentation/changes.tely:70: Lyrics above a staff must have their
@code{staff-affinity} set to
I don't think this is appropriate here.
If it must stay, it needs a snippet to show how 'staff-affinity and
alignAboveContext are used.
http://codereview.appspot.com/4061043/diff/1/Documentation/snippets/new/vocal-ensemble-template-with-automatic-piano-reduction.ly
File
Documentation/snippets/new/vocal-ensemble-template-with-automatic-piano-reduction.ly
(right):
http://codereview.appspot.com/4061043/diff/1/Documentation/snippets/new/vocal-ensemble-template-with-automatic-piano-reduction.ly#newcode6
Documentation/snippets/new/vocal-ensemble-template-with-automatic-piano-reduction.ly:6:
%% Translation of GIT committish:
fa19277d20f8ab0397c560eb0e7b814bd804ecec
remove all translation stuff
http://codereview.appspot.com/4061043/diff/1/Documentation/snippets/new/vocal-ensemble-template.ly
File Documentation/snippets/new/vocal-ensemble-template.ly (right):
http://codereview.appspot.com/4061043/diff/1/Documentation/snippets/new/vocal-ensemble-template.ly#newcode6
Documentation/snippets/new/vocal-ensemble-template.ly:6: %% Translation
of GIT committish: fa19277d20f8ab0397c560eb0e7b814bd804ecec
remove
http://codereview.appspot.com/4061043/diff/1/input/regression/mozart-hrn-3.ly
File input/regression/mozart-hrn-3.ly (right):
http://codereview.appspot.com/4061043/diff/1/input/regression/mozart-hrn-3.ly#newcode51
input/regression/mozart-hrn-3.ly:51: obsolete-between-system-space = 20
\mm system-system-spacing #'basic-distance = #(/
obsolete-between-system-space staff-space) score-system-spacing
#'basic-distance = #(/ obsolete-between-system-space staff-space)
On 2011/01/23 14:20:35, Graham Percival wrote:
ditto. hmm, maybe Keith's recent convert-ly patch has a problem?
It's deliberate, in case user scores have commented-out paper settings:
if these are converted, the obsolete-* variables are undefined, causing
Guile to complain.
http://codereview.appspot.com/4061043/
- Fix critical regressions to lyric spacing (issue4061043), Carl . D . Sorensen, 2011/01/22
- Re: Fix critical regressions to lyric spacing (issue4061043), tdanielsmusic, 2011/01/23
- Re: Fix critical regressions to lyric spacing (issue4061043), percival . music . ca, 2011/01/23
- Re: Fix critical regressions to lyric spacing (issue4061043),
n . puttock <=
- Re: Fix critical regressions to lyric spacing (issue4061043), Carl . D . Sorensen, 2011/01/23
- Re: Fix critical regressions to lyric spacing (issue4061043), Carl . D . Sorensen, 2011/01/23
- Re: Fix critical regressions to lyric spacing (issue4061043), k-ohara5a5a, 2011/01/24
- Re: Fix critical regressions to lyric spacing (issue4061043), percival . music . ca, 2011/01/24
- Re: Fix critical regressions to lyric spacing (issue4061043), Carl . D . Sorensen, 2011/01/24
- Re: Fix critical regressions to lyric spacing (issue4061043), percival . music . ca, 2011/01/25
- Re: Fix critical regressions to lyric spacing (issue4061043), Carl . D . Sorensen, 2011/01/25