lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix critical regressions to lyric spacing (issue4061043)


From: percival . music . ca
Subject: Re: Fix critical regressions to lyric spacing (issue4061043)
Date: Sun, 23 Jan 2011 14:20:35 +0000

I think we have a convert-ly problem.


http://codereview.appspot.com/4061043/diff/1/Documentation/snippets/new/lyrics-old-spacing-settings.ly
File Documentation/snippets/new/lyrics-old-spacing-settings.ly (right):

http://codereview.appspot.com/4061043/diff/1/Documentation/snippets/new/lyrics-old-spacing-settings.ly#newcode19
Documentation/snippets/new/lyrics-old-spacing-settings.ly:19: % VERSE
ONE
This differs from our normal indentation style... and in particular, it
conflicts with the two-space indentation style that you used above in
the global section... but meh, go ahead.

We'll have an auto-ly-indenter soon, so let's not fuss with this
manually.

http://codereview.appspot.com/4061043/diff/1/input/regression/baerenreiter-sarabande.ly
File input/regression/baerenreiter-sarabande.ly (right):

http://codereview.appspot.com/4061043/diff/1/input/regression/baerenreiter-sarabande.ly#newcode174
input/regression/baerenreiter-sarabande.ly:174:
obsolete-between-system-space = 25\mm  system-system-spacing
#'basic-distance = #(/ obsolete-between-system-space staff-space)
score-system-spacing #'basic-distance = #(/
obsolete-between-system-space staff-space)
woah, what happened here?  Could we get some linebreaks? (is this some
weird osx-linebreaks+git malfunction?)

http://codereview.appspot.com/4061043/diff/1/input/regression/mozart-hrn-3.ly
File input/regression/mozart-hrn-3.ly (right):

http://codereview.appspot.com/4061043/diff/1/input/regression/mozart-hrn-3.ly#newcode51
input/regression/mozart-hrn-3.ly:51: obsolete-between-system-space = 20
\mm  system-system-spacing #'basic-distance = #(/
obsolete-between-system-space staff-space)  score-system-spacing
#'basic-distance = #(/ obsolete-between-system-space staff-space)
ditto.  hmm, maybe Keith's recent convert-ly patch has a problem?

http://codereview.appspot.com/4061043/diff/1/input/regression/page-spacing.ly
File input/regression/page-spacing.ly (right):

http://codereview.appspot.com/4061043/diff/1/input/regression/page-spacing.ly#newcode71
input/regression/page-spacing.ly:71: obsolete-between-system-space = 1.0
 system-system-spacing #'basic-distance = #(/
obsolete-between-system-space staff-space)  score-system-spacing
#'basic-distance = #(/ obsolete-between-system-space staff-space)
ditto.

http://codereview.appspot.com/4061043/diff/1/input/regression/page-top-space.ly
File input/regression/page-top-space.ly (right):

http://codereview.appspot.com/4061043/diff/1/input/regression/page-top-space.ly#newcode25
input/regression/page-top-space.ly:25: obsolete-page-top-space = 3 \cm
top-system-spacing #'basic-distance = #(/ obsolete-page-top-space
staff-space)
ditto.

http://codereview.appspot.com/4061043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]