|
From: | n . puttock |
Subject: | Fix issue 1376 ambitus two accidentals. (issue4099044) |
Date: | Sun, 23 Jan 2011 18:00:23 +0000 |
LGTM. http://codereview.appspot.com/4099044/diff/1/input/regression/ambitus.ly File input/regression/ambitus.ly (right): http://codereview.appspot.com/4099044/diff/1/input/regression/ambitus.ly#newcode8 input/regression/ambitus.ly:8: Two noteheads are displayed even for a note with two different Tthe noteheads are printed in overstrike, so there's only one visible; the accidentals are prevented from colliding. http://codereview.appspot.com/4099044/diff/1/input/regression/ambitus.ly#newcode30 input/regression/ambitus.ly:30: \new Staff \relative c'{ c' { http://codereview.appspot.com/4099044/diff/1/lily/ambitus-engraver.cc File lily/ambitus-engraver.cc (right): http://codereview.appspot.com/4099044/diff/1/lily/ambitus-engraver.cc#newcode184 lily/ambitus-engraver.cc:184: && !((p.steps () == other.steps ()) indent http://codereview.appspot.com/4099044/diff/1/lily/ambitus-engraver.cc#newcode185 lily/ambitus-engraver.cc:185: && (p.get_alteration () != other.get_alteration ()))) indent http://codereview.appspot.com/4099044/
[Prev in Thread] | Current Thread | [Next in Thread] |