[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: remove bar-size and replace its usage by bar-extent (issue4025044)
From: |
percival . music . ca |
Subject: |
Re: remove bar-size and replace its usage by bar-extent (issue4025044) |
Date: |
Fri, 21 Jan 2011 13:50:22 +0000 |
The python bits looked fine. I tried a regtest comparison and didn't
see any change at all other than test-output-distance, so maybe
something went wrong. Should I see any difference in the graphical
output?
I think there's some debugging code in here that needs to be cleaned up.
http://codereview.appspot.com/4025044/diff/1/lily/bar-line.cc
File lily/bar-line.cc (right):
http://codereview.appspot.com/4025044/diff/1/lily/bar-line.cc#newcode30
lily/bar-line.cc:30: #include <iostream>
Why iostream? We have our own functions for printing, which (I think)
makes it easier to translate the text.
http://codereview.appspot.com/4025044/diff/1/lily/bar-line.cc#newcode342
lily/bar-line.cc:342: std::clog << __PRETTY_FUNCTION__ << ": (" <<
extent.at (DOWN) << " . "
I'm suspicious about printing text this way.
http://codereview.appspot.com/4025044/diff/1/lily/bar-line.cc#newcode367
lily/bar-line.cc:367:
Ditto.
http://codereview.appspot.com/4025044/
- Re: remove bar-size and replace its usage by bar-extent (issue4025044),
percival . music . ca <=
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), benko . pal, 2011/01/21
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), percival . music . ca, 2011/01/23
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), benko . pal, 2011/01/23
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), percival . music . ca, 2011/01/23
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), Carl . D . Sorensen, 2011/01/23
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), pkx166h, 2011/01/26
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), n . puttock, 2011/01/28
- Re: remove bar-size and replace its usage by bar-extent (issue4025044), benko . pal, 2011/01/28