[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fix Issue 1035 -- Add context property for negative frets (issue4056
|
From: |
marc |
|
Subject: |
Re: Fix Issue 1035 -- Add context property for negative frets (issue4056041) |
|
Date: |
Tue, 18 Jan 2011 19:42:41 +0000 |
Hi Carl,
LGTM - I don't think that many users will ever
change handleNegativeFrets, but your solution
is encompassing and leaves nothing to be desired ;-)
Regards,
Marc
http://codereview.appspot.com/4056041/diff/1/scm/translation-functions.scm
File scm/translation-functions.scm (right):
http://codereview.appspot.com/4056041/diff/1/scm/translation-functions.scm#newcode394
scm/translation-functions.scm:394: ((eq? handle-negative 'recalculate)
In case of a resulting negative fret there should be
at least a warning that lilypond recalculates the
fret on another string IMHO.
http://codereview.appspot.com/4056041/