Re: Make define-builtin-markup{,-list}-command #:category #:properties keywords (issue160048)

[nicolas . sceaux]

Hi,

Maybe this patch, as a first step, should focus on the unification of
the syntax of the two macros?

(define-markup-command (command-name layout props . arguments)
  arguments-signature
  #:properties property-bindings
  #:allow-other-keys
  #:rest body)

on the user side and:

(define-builtin-markup-command (command-name layout props . arguments)
  arguments-signature
  #:category doc-category
  #:properties property-bindings
  #:rest body)

on LilyPond side.

It would be a plus to make the #:category argument mandatory on the
builtin side (e.g. by giving it a default value that raises an error).
That argument would just be ignored on the user side (by
#:allow-other-keys).

What do you think?

Nicolas


http://codereview.appspot.com/160048