|
From: | Trevor Daniels |
Subject: | Re: [PATCH] Extended documentation on Turkish classical music and makam |
Date: | Thu, 3 Sep 2009 08:52:40 +0100 |
Joe, you wrote Thursday, September 03, 2009 7:20 AM
Trevor Daniels wrote:Thanks Joe. Initially these patches didn't apply either, but I traced the reason to their having DOS (CRLF) line endings rather than Unix (LF) line endings. When I changed that they applied fine. (This actually might have been the original problem too.) I don't know where the DOS line endings originate, but if you can track it down and generate patcheswith Unix line endings it would be helpful. Although I use WindowsI don't think the problem is at my end, as patches from others apply cleanly.That's very, very weird, because I'm running Linux (Kubuntu 9.10) and using Kate as an editor. I just checked Kate's settings, and it should be saving to UTF-8 with UNIX line endings. So I'm somewhat baffled.
It would be helpful to understand this, as I suspect many similar patch failings have been caused by line ending problems. It may be that the problem is at my end, so I've looked at the mail attachment as the mailer saves it in a temporary folder. A hex dump of the first few lines is below, and it does have CRLF endings there. Here's the hex: 46 72 6F 6D 20 65 33 65 38 61 33 39 31 36 61 33 66 66 63 33 33 38 33 36 61 65 65 30 34 37 32 32 61 63 39 63 62 33 62 33 61 65 64 38 35 20 4D 6F 6E 20 53 65 70 20 31 37 20 30 30 3A 30 30 3A 30 30 20 32 30 30 31 0D 0A 46 72 6F 6D 3A 20 4A 6F 73 65 70 68 20 57 61 6B 65 6C 69 6E 67 20 3C 6A 6F 73 65 70 68 2E 77 61 6B 65 6C 69 6E 67 40 77 65 62 64 72 61 6B 65 2E 6E 65 74 3E 0D 0A 44 61 74 65 3A 20 54 75 65 2C 20 31 20 53 65 70 20 32 30 30 39 20 32 31 3A 33 33 3A 34 31 20 2B 30 32 30 30 0D 0A 53 75 62 6A 65 63 74 3A 20 5B 50 41 54 43 48 20 31 2F 32 5D 20 45 78 74 65 6E 64 65 64 20 64 6F 63 75 6D 65 6E 74 61 74 69 6F 6E 20 6F 6E 20 54 75 72 6B 69 73 68 20 63 6C 61 73 73 I then looked at the actual mail message. You're using Thunderbird with inline attachments and quoted-printable encoding. This is the problem. I seem to remember Jonathan Kulp discovering that Thunderbird messed up the line endings of patches. I'm not familiar with Thunderbird. Are you able to set it up with a different content-disposition, maybe something to send a file as binary, ie unmolested? If not, do you have access to another mailer? Trevor
[Prev in Thread] | Current Thread | [Next in Thread] |