Re: [PATCH] translations: Make "GIT Committish:" lines obsolete

[Johannes Schindelin]

Hi,

On Sat, 13 Jan 2007, John Mandereau wrote:

> If a translator polishes translation of a page and commit without 
> running check-translation first, he will miss changes in English pages.

If the translator does not commit halfway through _and_ pull _and_ 
continues polishing _and_ commits without checking translation first, it 
still works.

My patch works like this: for every file to check, find the most recent 
commit which changed that file. Compare the version of the corresponding 
_English_ file in the working tree with the version in that commit.

So something like

1. translate
2. hack hack hack
3. polish translation
4. pull upstream
5. check

still works as expected.

> I'd prefer a script that update the committishes in translated pages 
> automatically when a translator has made sure the translation is synced 
> with the last fetched remote head.

That is reasonably easy, too, but will add one commit. Of course, the 
commit then says "I checked the translation at this stage and am confident 
it is up-to-date", which might be a desired thing.

> > It is perfectly possible that the translater copies the entire site
> > (currently identifying and freezing the original copy by adding Git
> > Committish: <> in those files), translates all files, and commits 2
> > weeks later.  In the mean time, the original site has seen several
> > updates.
> 
> Agreed.  This is even very probable, as Git newbies may pull several
> times before they understand they should add and commit newly translated
> files.

Yes, this is a problem.

> > Using this patch, will the correct diff be shown to the translator to
> > help her incorporating the changes made in the mean time?
> 
> After a quick test, I say "yes", but only if you do things right from
> the beginning with Git, which is seldom true.  Current check-translation
> system is slightly more tolerant and reliable IMHO.

As I said, it was a fun exercise.

Ciao,
Dscho