Re: [PATCH] translations: Make "GIT Committish:" lines obsolete

[Till Rettig]

A bit off-topic:
Well, I don't know anything about python, but have to say that the current script doesnt't work for me or I didn't understand it so far. That is, I just did the check-translation and it showed fatal error about some git comment numbers. So I changed *all* commitishes that were in my de-tree. And then the script run without any comment. But I know that there were changes in the files -- so I had to go through them all by Hand, comparing English and German versions. Shouldn't the script just say that: here were some changes? And how can it do this if it doesn't accept my commitish numbers -- I understand that when I insert the last available commitish the script doesn't find any differences, because it obviously searches for commitish numbers to say: in the last commitish this file was changed, and your commitish is older... and so on. And I just inserted the last commitish.
But then, why did it not accept my commitish numbers in the first case?

Greetings
Till

Jan Nieuwenhuizen wrote:

Johannes Schindelin <address@hidden> writes:

  

Use git to determine when the translation last changed instead of
relying on the "GIT Committish" line.
    

Thanks for helping to solve this silly Git issue.  However, I do not
understand, how can Git know what original version was translated?

It is perfectly possible that the translater copies the entire site
(currently identifying and freezing the original copy by adding Git
Committish: <> in those files), translates all files, and commits 2
weeks later.  In the mean time, the original site has seen several
updates.

Using this patch, will the correct diff be shown to the translator to
help her incorporating the changes made in the mean time?

Greetings,
Jan.