[Libunwind-devel] [PATCH 5/5] Fix file descriptor leakage in maps_init

[Ken Werner]

From: Zachary T Welch <address@hidden>

If mmap fails, be sure to close the maps file before returning an error.

Signed-off-by: Zachary T Welch <address@hidden>
Signed-off-by: Ken Werner <address@hidden>
---
 src/os-linux.h |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/src/os-linux.h b/src/os-linux.h
index af301ce..4e225dc 100644
--- a/src/os-linux.h
+++ b/src/os-linux.h
@@ -80,7 +80,11 @@ maps_init (struct map_iterator *mi, pid_t pid)
       cp = mmap (0, mi->buf_size, PROT_READ | PROT_WRITE,
                 MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
       if (cp == MAP_FAILED)
-       return -1;
+       {
+         close(mi->fd);
+         mi->fd = -1;
+         return -1;
+       }
       else
        {
          mi->offset = 0;
-- 
1.7.4.1