[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Libunwind-devel] [PATCH 0/5] some minor fixes

From: Ken Werner
Subject: [Libunwind-devel] [PATCH 0/5] some minor fixes
Date: Wed, 2 Mar 2011 17:40:05 +0100

I'm trying to build libunwind and its testsuite on ARMv7 and ran into a few 
issues. This series of patches attempts to fix them.

The first patch allows the testsuite to work with linkers that do not pull in 
indirect shared libs (.so files that depend on other shared libs via 
DT_NEEDED). Recent Linux distributions such as Fedora, Debian or Ubuntu enable 
the --no-add-needed/--no-copy-dt-needed-entries option of the GNU ld to mimic 
the behavior of the gold linker. More details can be found at:

The second patch fixes the build of the test-static-link test case on ARM. It 
uses the UNW_OBJ macro instead of UNWI_ARCH_OBJ to rename unwi_unwind_method. 
Otherwise this symbol would be in libunwind-arm.a and libunwind.a that prevents 
them from being linked in into one executable. 

The third patch adds libunwind-elf to libunwind_setjmp_la_LIBADD. The 
test-setjmp test case depends on the which depends on a 
symbol (_Uelf32_valid_object) from the libunwind-elf32.a. This results in a 
linker error on my system.

The fourth patch was made by Zach Welch. It fixes the test-ptrace argument 

The fifth patch - also made by Zach - ensures that the file descriptor gets 
closed in case the mmap fails (os-linux.h:maps_init).

Ken Werner (3):
  Explicitly add dependent shared libraries.
  Use UNW_OBJ instead of UNWI_ARCH_OBJ to rename unwi_unwind_method on
  Link libunwind-setjmp against libunwind-elf.

Zachary T Welch (2):
  Fix test-ptrace argument parsing.
  Fix file descriptor leakage in maps_init

 include/tdep-arm/libunwind_i.h |    2 +-
 src/                |   29 +++++++++++++-----------
 src/os-linux.h                 |    6 ++++-
 tests/              |   47 ++++++++++++++++++++-------------------
 tests/test-ptrace.c            |    2 +
 5 files changed, 48 insertions(+), 38 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]