[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 22/25] syntax-check: enable sc_bindtextdomain.
From: |
Gary V . Vaughan |
Subject: |
Re: [PATCH 22/25] syntax-check: enable sc_bindtextdomain. |
Date: |
Wed, 16 Nov 2011 09:26:57 +0700 |
Hi Stefano,
Thanks for the review.
> On Tuesday 15 November 2011, Gary V wrote:
>> * cfg.mk (local-checks-to-skip): Remove sc_bindtextdomain
>> list of disabled checks.
>> (exclude_file_name_regexp--sc_program_name): Don't check demo
> s|set_program_name|bindtextdomain| here?
>
>> programs for use of set_program_name.
>>
> And here as well?
Oops. Fixed. Thanks.
> But then again, if libtool isn't internationalized, what is the point
> of enabling the `sc_bindtextdomain' check?
We might add i18n to libtool someday, and I like having more checks even
if they don't (yet) catch anything, rather than fewer checks.
Cheers,
--
Gary V. Vaughan (gary AT gnu DOT org)
- [PATCH 14/25] syntax-check: fix violations and re-enable sc_prohibit_magic_number_exit., (continued)
- [PATCH 14/25] syntax-check: fix violations and re-enable sc_prohibit_magic_number_exit., Gary V. Vaughan, 2011/11/15
- [PATCH 15/25] syntax-check: fix violations and re-enable sc_prohibit_stddef_without_use., Gary V. Vaughan, 2011/11/15
- [PATCH 17/25] syntax-check: fix violations and re-enable sc_probibit_test_minus_ao., Gary V. Vaughan, 2011/11/15
- [PATCH 16/25] syntax-check: fix violations and re-enable sc_prohibit_strcmp., Gary V. Vaughan, 2011/11/15
- [PATCH 18/25] syntax-check: fix violations and re-enable sc_prohibit_undesirable_word_seq., Gary V. Vaughan, 2011/11/15
- [PATCH 20/25] syntax-check: fix violations and re-enable sc_useless_cpp_parens., Gary V. Vaughan, 2011/11/15
- [PATCH 19/25] syntax-check: fix violations and re-enable sc_space_tab., Gary V. Vaughan, 2011/11/15
- [PATCH 22/25] syntax-check: enable sc_bindtextdomain., Gary V. Vaughan, 2011/11/15
- [PATCH 23/25] syntax-check: enable sc_program_name., Gary V. Vaughan, 2011/11/15
[PATCH 24/25] syntax-check: enable sc_prohibit_always_true_header_tests., Gary V. Vaughan, 2011/11/15
[PATCH 25/25] dist: hook syntax-check into `make distcheck'., Gary V. Vaughan, 2011/11/15
[PATCH 21/25] syntax-check: fix violations and implement sc_trailing_blank-non-rfc3676., Gary V. Vaughan, 2011/11/15