Re: [PATCH 23/25] syntax-check: enable sc_program_name.

[Stefano Lattarini]

Hi Gary.

On Wednesday 16 November 2011, Gary V wrote:
> Hi Stefano,
> 
> Thanks for the review.
> 
> >> 
> >> # GPL_version: checks for GPLv3, which we don't use
> >> -# program_name: libtool has no programs!
> >> 
> > But then, since libtool doesn't offer any "real" program, what is
> > the point of enabling the `sc_program_name' check?
> 
> Quite arguably, there is no point at the moment.
>
So at least I haven't misunderstood the scope/meaning of your change ...
Good for me, I was suspecting to be missing something obvious :-)

> But at some point
> we may grow a "real" program (ltmain.c has been on the horizon for
> many years), and letting syntax-check run everything it has if at all
> possible means we won't have to remember to go back and enable those
> additional NOP tests if that day ever arrives.
> 
> If you object strongly, I can be persuaded to change my mind however.
>
I don't object *strongly*; it just seems confusing to me to add checks
for a feature/setup that is not yet implemented, nor is planned to be
implemented in the near future.  I leave the decision of whether this
is worth worrying about to you.

Regards,
  Stefano