[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [3/11] Native MSVC support (msvc-cwrapper)
From: |
Peter Rosin |
Subject: |
Re: [3/11] Native MSVC support (msvc-cwrapper) |
Date: |
Sat, 21 Jul 2007 10:55:23 +0200 |
User-agent: |
Mutt/1.5.12-2006-07-14 |
On Thu, Jul 19, 2007 at 05:47:36PM -0400, Charles Wilson wrote:
> Ralf Wildenhues wrote:
> >Hello Charles, Peter,
> >>In case it wasn't clear, I think this patch should go in sooner rather
> >>than later, as it also fixes an existing problem in the cwrapper w.r.t.
> >>intptr_t.
> >
> >I don't mind the patch going in, but isn't
> > +# define _stat stat
> >
> >the wrong way around, or at least superfluous?
>
> You're right, it is the wrong way around. I would suspect also that if
> it compiles as-is under MSVC, then it is unnecessary. However, from
> reading the msdn docs, it seems that the correct define:
>
> # define stat _stat
>
> SHOULD be necessary, for both 'stat() ==> _stat()' and 'struct stat ==>
> struct _stat' usages. Peter, can you clarify?
The cwrapper has two targets (cygwin, mingw), I'm adding a third (msvc).
Both the previous targets has stat as stat, cygwin doesn't have _stat
and msvc doesn't have stat (unless you link with OLDNAMES.LIB).
So, going the other way around breaks cygwin (IIRC). But I guess mingw
could drop stat at some point as well (and require -loldnames) in order
to match the MS libc. I think mingw has _stat already.
Should I commit as is?
Cheers,
Peter
[3/11] Native MSVC support (msvc-cwrapper), Peter Rosin, 2007/07/10
- Re: [3/11] Native MSVC support (msvc-cwrapper), Charles Wilson, 2007/07/12
- Re: [3/11] Native MSVC support (msvc-cwrapper), Charles Wilson, 2007/07/18
- Re: [3/11] Native MSVC support (msvc-cwrapper), Ralf Wildenhues, 2007/07/19
- Re: [3/11] Native MSVC support (msvc-cwrapper), Charles Wilson, 2007/07/19
- Re: [3/11] Native MSVC support (msvc-cwrapper), Bob Friesenhahn, 2007/07/19
- Re: [3/11] Native MSVC support (msvc-cwrapper), Gary V. Vaughan, 2007/07/20
- Re: [3/11] Native MSVC support (msvc-cwrapper),
Peter Rosin <=
- Re: [3/11] Native MSVC support (msvc-cwrapper), Charles Wilson, 2007/07/21
- Re: [3/11] Native MSVC support (msvc-cwrapper), Peter Rosin, 2007/07/22
[4/11] Native MSVC support (file-magic-glob), Peter Rosin, 2007/07/10
- Re: [4/11] Native MSVC support (file-magic-glob), Charles Wilson, 2007/07/12
- Re: [4/11] Native MSVC support (file-magic-glob), Peter Rosin, 2007/07/12
- Re: [4/11] Native MSVC support (file-magic-glob), Paolo Bonzini, 2007/07/13
- Re: [4/11] Native MSVC support (file-magic-glob), Ralf Menzel, 2007/07/13
- Re: [4/11] Native MSVC support (file-magic-glob), Paolo Bonzini, 2007/07/13
- Re: [4/11] Native MSVC support (file-magic-glob), Peter Rosin, 2007/07/17
- Re: [4/11] Native MSVC support (file-magic-glob), Eric Blake, 2007/07/17