[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: deplibs_check_method=test_compile (was: new keywords for testsuite)
From: |
Gary V. Vaughan |
Subject: |
Re: deplibs_check_method=test_compile (was: new keywords for testsuite) |
Date: |
Sat, 04 Feb 2006 01:38:53 +0000 |
User-agent: |
Mozilla Thunderbird 1.0.6 (Macintosh/20050716) |
Hallo Ralf,
Ralf Wildenhues wrote:
> ..and if you try it with `deplibs_check_method=test_compile', then
> you will note spurious errors during linking. This mostly trivial
> patch fixes them. OK to apply?
Comments inline.
> * libltdl/config/ltmain.m4sh (func_mode_link) < test_compile >:
> Fix a couple of instances where `test .. -ne ..' would possibly
> compare non-numbers. Clean up a bit.
>
> Index: libltdl/config/ltmain.m4sh
> ===================================================================
> RCS file: /cvsroot/libtool/libtool/libltdl/config/ltmain.m4sh,v
> retrieving revision 1.32
> diff -u -r1.32 ltmain.m4sh
> --- libltdl/config/ltmain.m4sh 30 Jan 2006 20:20:54 -0000 1.32
> +++ libltdl/config/ltmain.m4sh 31 Jan 2006 13:59:03 -0000
> @@ -4592,13 +4640,12 @@
> int main() { return 0; }
> EOF
> $opt_dry_run || $RM conftest
> - $LTCC $LTCFLAGS -o conftest conftest.c $deplibs
> - if test "$?" -eq 0 ; then
> + if $LTCC $LTCFLAGS -o conftest conftest.c $deplibs; then
> ldd_output=`ldd conftest`
> for i in $deplibs; do
> name=`expr $i : '-l\(.*\)'`
> # If $name is empty we are operating on a -L argument.
> - if test "$name" != "" && test "$name" -ne "0"; then
> + if test "$name" != "" && test "$name" != 0; then
^^
s/-ne/!=/ agreed... but I prefer to leave "0" alone.
> if test "X$allow_libtool_libs_with_static_runtimes" = "Xyes" ;
> then
> case " $predeps $postdeps " in
> *" $i "*)
> @@ -4635,11 +4682,9 @@
> for i in $deplibs; do
> name=`expr $i : '-l\(.*\)'`
> # If $name is empty we are operating on a -L argument.
> - if test "$name" != "" && test "$name" != "0"; then
> + if test "$name" != "" && test "$name" != 0; then
^^
Huh? != is the string comparison operator, so I like that it was
explicit with "0". Does this really cause a spurious error?
> $opt_dry_run || $RM conftest
> - $LTCC $LTCFLAGS -o conftest conftest.c $i
> - # Did it work?
> - if test "$?" -eq 0 ; then
> + if $LTCC $LTCFLAGS -o conftest conftest.c $i; then
> ldd_output=`ldd conftest`
> if test "X$allow_libtool_libs_with_static_runtimes" = "Xyes"
> ; then
> case " $predeps $postdeps " in
> @@ -4671,7 +4716,7 @@
> droppeddeps=yes
> $ECHO
> $ECHO "*** Warning! Library $i is needed by this library but
> I was not able to"
> - $ECHO "*** make it link in! You will probably need to
> install it or some"
> + $ECHO "*** make it link in! You will probably need to
> install it or some"
> $ECHO "*** library that it depends on before this library
> will be fully"
> $ECHO "*** functional. Installing it before continuing would
> be even better."
> fi
Just nit-picking really. If you would rather drop the quotes, I'm
not overly fussed. Yes, please apply.
Cheers,
Gary.
--
Gary V. Vaughan ())_. address@hidden,gnu.org}
Research Scientist ( '/ http://tkd.kicks-ass.net
GNU Hacker / )= http://www.gnu.org/software/libtool
Technical Author `(_~)_ http://sources.redhat.com/autobook
signature.asc
Description: OpenPGP digital signature