Re: new keyword `libtool' for testsuite

[Gary V. Vaughan]

Hallo Ralf!

Ralf Wildenhues wrote:
> This trivial patch adds the Autotest keyword `libtool' to all tests that
> exercise the $top_builddir/libtool script.  With the patch and the fixes
> in CVS Autoconf's autotest macros, it is possible to do neat things, for
> example:
> - test a branch-1-5 libtool script by overriding $LIBTOOL suitably
>   (I do this currently by manually calling `testsuite' in the way the
>   Makefile calls it).
> - manually set `need_lib_prefix' to yes and get some test exposure by
>     make check-local TESTSUITE_FLAGS='-k libtool'
> - do likewise for other flags; e.g., `need_locks' and `compiler_c_o';
>   or set `deplibs_check_method="test_compile"'

Neat!

> A subsequent post-Libtool-2.0 post-Autoconf-2.60 patch will actually
> create tests that do some of the above by default.

Cool!

> OK to apply this patch?

Most definitely :-)

> Should we maybe add documentation somewhere about the exact meaning of
> the testsuite keywords?

A good idea.  I guess a few words in HACKING should be enough.

>         * tests/convenience.at, tests/deplibs-ident.at: Add new keyword
>         `libtool' for tests that exercise the unmodified `libtool'
>         script that is generated at build time.
>         * tests/duplicate_members.at, tests/fail.at: Likewise.
>         * tests/inherited_flags.at, tests/link-order.at: Likewise.
>         * tests/stresstest.at, tests/template.at: Likewise.

Cheers,
        Gary.
-- 
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature