[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Libreboot-dev] Why do you carry 0042-cpu-amd-car-Initialize-entire-CAR-

From: xdrudis
Subject: [Libreboot-dev] Why do you carry 0042-cpu-amd-car-Initialize-entire-CAR-space-instead-of-o.patch ?
Date: Tue, 22 Dec 2015 23:19:51 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

Hello, and thank you very much for your work.

I'm looking at the code and I see that libreboot is patching coreboot
with a change that was abandoned in coreboot: 


I'm not good at assembler but from what I've read I think the 
original code was right and the patch introduces a bug, because
rep lodsl or rep stosl copy 4 bytes, so we only have to repeat
this CacheSize/4 times (= CacheSize / 2^2 = CacheSize >> 2).

I can't test now but I'll reply if/ when I can test it. 
But I thought I'd ask because I may be missing something. 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]