[libextractor] Re: OOo mimetype patch (Re: About libextractor 0.4.2 - 0.5.2)

[Christian Grothoff]

Hi Ronan!

I've fixed a bug in the OO code for LE 0.5.2 and also applied your patch, so 
the OO plugin now works again properly.  Oh, and the order in which the 
plugins are run is determined by the list in src/main/extractor.c.  

I am still looking into a problem with libgsf/OLE2 extractor for doc files, 
once that is in (and maybe on-the-fly decompression for bz2) I'll release the 
next version.

Thanks for the patch!

Christian

On Wednesday 10 August 2005 07:07, you wrote:
> Hello Christian,
>
> Please file attached (as a ZIP file) my patch
> for libextractor 0.4.2 to extract OpenOffice documents
> mimetypes.
>
> As outlined yesterday the idea is to read the contents
> of the mimetype archive member. See
>     'libextractor-0.4.2.src/plugins/oo/ooextractor.c'
> in  attached ZIP file.
>
> To avoid retrieving internal member archive names as is done
> with regular ZIP archives, I've added a test at the beginning
> of libextractor_lib_extract() to check whether extraction was
> already done. This is a hack (I'd rather not call
> libextractor_zip_extract() at all in this case),
> since I have yet to understand the general activation logic
> (how do you decide that libextractor_oo_extract()
>  should be called first ?). See :
>      'libextractor-0.4.2.src/plugins/zipextractor.c'
> in attached ZIP file.
>
> Regression tests were minimal : I've checked that the results
> are correct on an OpenOffice Writer file and stay correct
> with a regular ZIP file.
>
> For the record there now exists a more recent (February 2005)
> version of minizip (unzip.[ch], etc).
>
> Cordially,
> --
> Ronan Melennec          | DGAC/DSNA/DTI/SDER/3/RFM
> <address@hidden>  | Division Routes, Flux et Modélisations (RFM)
> +33 (0) 1 69 57 69 28   | Orly Sud 205 -- 94542 ORLY AEROGARE CEDEX
> --