[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libcdio-devel] Fedora bug report concerning CD-TEXT

From: Rocky Bernstein
Subject: Re: [Libcdio-devel] Fedora bug report concerning CD-TEXT
Date: Sun, 3 Apr 2016 09:43:15 -0400

The commit message has been updated in that branch. Following the first line is short while the
subsequent lines after the 2nd blank line have a more thorough description.

This was "force-pushed" into the parsing-CD-Text-short-fields branch to get
that new commit message in.

One way I would like libcdio to be different than say cdrdao is that what
goes on is discussed more openly (mission accomplished here), and that the
commit messages summarize that discussion and point the full discussion.

On Sun, Apr 3, 2016 at 7:16 AM, Leon Merten Lohse <address@hidden>

> On Sat, 2 Apr 2016 21:52:50 -0400
> Rocky Bernstein <address@hidden> wrote:
> > But I would like the commit message to be something better than:
> >   Fix incorrect parsing of CD-Text with short fields
> >
> > As best as I can tell from reading the code, when a particular loop
> > has to iterated more than once we need to also increase the track
> > number. Is that right? If so, none of that seems reflected by that
> > commit message.
> True. But it also fixes the (CD-Text related part of the) bug reported
> by James Olin Oden.
> How about:
>   fix: track number was not increased after parsing short CD-Text fields
> > Finally, if you want me or others to look over patches (with a good
> > level of precision), the most error prone way is to do it via cutting
> > and pasting from list archives. The best would be just to do what I
> > did: create a branch in libcdio and apply the change. If git isn't
> > your thing, then submit the patch via
> >
> Will do. Thanks. There are a few more fixes on the way.
> Regards
> Leon

reply via email to

[Prev in Thread] Current Thread [Next in Thread]