[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libcdio-devel] Fedora bug report concerning CD-TEXT

From: Rocky Bernstein
Subject: Re: [Libcdio-devel] Fedora bug report concerning CD-TEXT
Date: Sat, 2 Apr 2016 21:52:50 -0400

This patch looks good to me. I have applied it in a branch called
parsing-CD-Text-short-fields. Unless others have a problem with this, I
will merge it into the master branch in a couple of days.

But I would like the commit message to be something better than:
  Fix incorrect parsing of CD-Text with short fields

As best as I can tell from reading the code, when a particular loop has to
iterated more than once we need to also increase the track number. Is that
right? If so, none of that seems reflected by that commit message.

Finally, if you want me or others to look over patches (with a good level
of precision), the most error prone way is to do it via cutting and pasting
from list archives. The best would be just to do what I did: create a
branch in libcdio and apply the change. If git isn't your thing, then
submit the patch via


On Sat, Apr 2, 2016 at 3:27 AM, Leon Merten Lohse <address@hidden>

> On Thu, 31 Mar 2016 06:07:22 -0400
> Rocky Bernstein <address@hidden> wrote:
> > Let me know how I can be of help after this is resolved.
> Could you take a look at the patch I sent over the list? [1]
> Thanks a lot!
> Best regards
> Leon
> [1]

reply via email to

[Prev in Thread] Current Thread [Next in Thread]